Repository navigation
Phone pushes follow the notification settings (GRYT-1696) - #314
Merged
Merged
Conversation
…everyone unless suppressed (GRYT-1696) When the phone signs up a server for pushes, it now sends two more things: which conversations it has at "All messages", and whether @everyone and @here get through. "All" is resolved the way the notification settings already resolve it: the phone's own choice, else the server's level quietened by the channel's default, with the global level as a ceiling. @everyone gets through unless "Suppress @everyone" is on. The server half then pushes every message in those channels, and @everyone where it's allowed. The default is All, as on the desktop. So after this, a channel nobody has turned down pushes every message. That's what you asked for, and it's the line to change if it turns out too loud. The opt-in question now says pushes follow the notification settings, rather than listing mentions and DMs. The server half is in Gryt-chat/server, and it waits for review. An older server ignores the new fields, so this is safe to ship first. Not seen end to end: the simulator never gets a push token. `loudConversations` has tests for the default, overrides both ways, a server or global level of mentions, and a muted channel. The server half's tests cover what the server does with the lists. tsc is clean and the notify tests pass. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the phone signs up a server for pushes, it now sends two more things: which conversations it has at "All messages", and whether @everyone and @here get through. "All" is resolved the way the notification settings already resolve it: the phone's own choice, else the server's level quietened by the channel's default, with the global level as a ceiling. @everyone gets through unless "Suppress @everyone" is on. The server half then pushes every message in those channels, and @everyone where it's allowed.
The default is All, as on the desktop. So after this, a channel nobody has turned down pushes every message. That's what you asked for, and it's the line to change if it turns out too loud.
The opt-in question now says pushes follow the notification settings, rather than listing mentions and DMs.
The server half is Gryt-chat/server#285, and it waits for review. An older server ignores the new fields, so this is safe to ship first.
Not seen end to end: the simulator never gets a push token.
loudConversationshas tests for the default, overrides both ways, a server or global level of mentions, and a muted channel. The server half's tests cover what the server does with the lists. tsc is clean and the notify tests pass.🤖 Generated with Claude Code