Skip to content

The phone says when a channel follows its folder (GRYT-1306) - #234

Merged
sivert-io merged 1 commit into
mainfrom
claude/GRYT-1306-folder-permissions
Sep 21, 2026
Merged

sivert-io merged 1 commit into
mainfrom
claude/GRYT-1306-folder-permissions

Conversation

@sivert-io

@sivert-io sivert-io commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

Task: GRYT-1306. Server: Gryt-chat/server#207. Desktop: Gryt-chat/client#632.

The phone's half of folder permissions. The phone doesn't edit folders, so this shows what applies and stops a Save from undoing it by accident.

What changed

  • Channel permissions says whether a channel follows its folder. ChannelScopeScreen reads followsFolder and folder from server:channels:scope. A following channel gets "Follows the Staff folder. Pick something here to give this channel its own permissions. You can change the folder's permissions in the desktop app." One with its own gets "Has its own permissions instead of the Staff folder's." and a Follow folder button, which sends server:channels:scope:follow and stays on the screen for the server's answer. An older server sends neither field, and the screen looks the same as before.
  • Save stays greyed out for Custom until a cell changes. A channel following a folder with rules of its own shows them as Custom, and saving them unchanged would have given the channel its own copy.
  • Folders the server leaves out need nothing new. flattenSidebar already draws only the folders it's sent, with their channels. The empty-folder hiding from GRYT-1305 stays for older servers, and the comments say so.

Editing a folder's permissions on the phone is GRYT-1348. The line above says where to do it for now.

Verified

npx tsc --noEmit, yarn test (827, with new cases for sameRules and describeFolderFollow) and yarn test:comment-length. Not run on a device or the simulator. The screen change is a line of text, one button that sends one event, and a helper with tests.

🤖 Generated with Claude Code

A channel in a folder gets a line above its permission choices. Either it
follows the folder, or it has its own permissions and there's a Follow
folder button. The phone can't edit a folder, so the first line also says
the folder's permissions can be changed in the desktop app.

Save stays greyed out for Custom until a cell changes. A channel that
follows a folder with rules of its own shows those rules as Custom, and
pressing Save on them unchanged would have given it its own copy.

A newer server doesn't send a folder nobody can see into, so the
empty-folder hiding only matters against an older one. The comments say
that now.

Co-Authored-By: Claude Opus 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant