Repository navigation
The phone says when a channel follows its folder (GRYT-1306) - #234
Merged
Merged
Conversation
A channel in a folder gets a line above its permission choices. Either it follows the folder, or it has its own permissions and there's a Follow folder button. The phone can't edit a folder, so the first line also says the folder's permissions can be changed in the desktop app. Save stays greyed out for Custom until a cell changes. A channel that follows a folder with rules of its own shows those rules as Custom, and pressing Save on them unchanged would have given it its own copy. A newer server doesn't send a folder nobody can see into, so the empty-folder hiding only matters against an older one. The comments say that now. Co-Authored-By: Claude Opus 5 <[email protected]>
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: GRYT-1306. Server: Gryt-chat/server#207. Desktop: Gryt-chat/client#632.
The phone's half of folder permissions. The phone doesn't edit folders, so this shows what applies and stops a Save from undoing it by accident.
What changed
ChannelScopeScreenreadsfollowsFolderandfolderfromserver:channels:scope. A following channel gets "Follows the Staff folder. Pick something here to give this channel its own permissions. You can change the folder's permissions in the desktop app." One with its own gets "Has its own permissions instead of the Staff folder's." and a Follow folder button, which sendsserver:channels:scope:followand stays on the screen for the server's answer. An older server sends neither field, and the screen looks the same as before.flattenSidebaralready draws only the folders it's sent, with their channels. The empty-folder hiding from GRYT-1305 stays for older servers, and the comments say so.Editing a folder's permissions on the phone is GRYT-1348. The line above says where to do it for now.
Verified
npx tsc --noEmit,yarn test(827, with new cases forsameRulesanddescribeFolderFollow) andyarn test:comment-length. Not run on a device or the simulator. The screen change is a line of text, one button that sends one event, and a helper with tests.🤖 Generated with Claude Code