Repository navigation
Choosing a group picture replaced your own avatar (GRYT-1182) - #214
Merged
Merged
Conversation
The group dialog's upload went through /api/uploads/avatar, which also sets the picture as the uploader's avatar on that server. It uses the new /api/uploads/group-icon route now. A server without that route answers 404. The app doesn't retry on the avatar route, since that would bring the bug back. It says the server needs an update and the group keeps its drawn egg. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vikunja: GRYT-1182. Needs the server route from Gryt-chat/server#185. Client: Gryt-chat/client#561. Docs: Gryt-chat/docs#108.
The group dialog uploaded its picture through
/api/uploads/avatar, the same as the desktop client. That route also made the picture your own avatar on that server.ServerScreenuses the new/api/uploads/group-iconroute now, throughconnection/groupPicture.ts.Older servers: if the new route answers 404, the app doesn't fall back to the avatar route, because that brings the bug back. The dialog shows "This server needs an update before groups can have their own picture." and the group keeps its drawn egg. No released server has the route yet, so merge this after the server release.
groupPicture.test.tscovers the route and header, a refusal passing on the server's message, and a 404 giving the update message without a second request to the avatar route.I didn't run this one on a phone. The request is the same shape as before, only the path and the reply field changed, and the desktop client was checked end to end against the server branch.
npx tsc --noEmit,yarn testand the comment check pass locally.🤖 Generated with Claude Code