Repository navigation
Webhooks page: bad JSON is a 400 and big bodies a 413 now (GRYT-1198) - #112
Merged
Merged
Conversation
Server#188 made the send route answer malformed JSON with 400 invalid_json and a body over 256 KB with 413 body_too_large. Until then both were 500s, and the page warned about that. The vendored openapi.json is copied from server main. The error table gets both rows, and the warning becomes a line about older servers. Rate limits now say those two are refused before they're counted. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vikunja: GRYT-1198. Follows Gryt-chat/server#188, which is merged.
The webhook send route used to answer malformed JSON, and any body over 2 MB, with
500 internal_error. Server#188 changed that to400 invalid_jsonfor bad JSON and413 body_too_largeover 256 KB, which is what the spec already promised for size.src/components/webhooks/openapi.jsonis copied from server main, sotest:webhook-specpasses again.Calloutimport is gone.Checked locally:
yarn test:comment-length,yarn test:webhook-specagainst the server branch,yarn build.🤖 Generated with Claude Code