Repository navigation
A loader on attachments the server is still processing, and the sandbox converts chat videos with sound (GRYT-1669) - #784
Merged
Conversation
…ox converts chat videos with sound (GRYT-1669) Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client half of Gryt-chat/server#277 and Gryt-chat/image-worker#47.
processingis drawn as a box in its own shape with a spinner and "Processing…". The sender's local picture shows faded behind it when there is one.chat:attachmentsswaps in the finished attachment.refusedshows "… couldn't be processed, so it isn't shown."chatvideojob converts with mediabunny to AV1 + Opus in MP4, inside 1280px (even sides, never enlarged), at most 30 fps, with the frames themselves rotated (no rotation tag). The input formats are listed by hand (MP4, QuickTime, Matroska, WebM), which leaves out HLS. The poster is taken from the converted file. Chat videos get a ten-minute limit.Tested: live against a Docker server and worker, through the real composer (loader on, then off at 0.75 s, video plays with audio decoded, fake HLS refused). In Electron 40 the sandbox converted the same eight files, and refused HLS-as-mp4, random bytes and a truncated MP4.
check-media-sandbox.mjscoverschatVideoSizeand the new job kind.A server without these changes sends no
processing, so nothing changes against it.🤖 Generated with Claude Code