Repository navigation
Chat emoji picker: the Gryt UI picker, with this server's emoji first - #773
Merged
Merged
Conversation
…irst The chat had its own picker. It now uses @gryt/ui's EmojiPicker, the one the card editor already uses, so both look and search the same. Custom emoji are kept per server, so a picker shows the emoji of the server it is on rather than whichever server loaded last. Taken from client#770 (Codex), as its own change. Co-Authored-By: Claude Opus 5.5 <[email protected]> Co-Authored-By: OpenAI Codex <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emoji picker part of #770, on its own so it can be reviewed.
@gryt/ui'sEmojiPicker, the same one the card editor uses. It's virtualised, has category jumps, and puts this server's custom emoji first, then recently used, then the Unicode set.emojiData.ts). The old cache held whichever server loaded last, so a picker could offer another server's emoji.thumbsup.The code is Codex's from #770, which I read through. I didn't change the logic. What to look at:
getCustomEmojis(serverHost)without a host still returns the last server loaded, as before, for callers that don't pass one.🤖 Generated with Claude Code