Repository navigation
DIS-2941: Editing Volume Numbers in a Series Does Not Save - #86
Merged
Merged
Conversation
Added new variable "userDefinedVolume" to track whether or not volume information should be overwritten during indexing. Gets set to true if user edits the volume field on an entry Gets set back to false if the user defined value is equal to the value found during indexing Update GroupedWorkIndexer.java: - When checking if we should add series member with volume, check if we are looking at an existing series member with a user defined volume in addition to checking if the volume exists The following needs to be true to add a new series member with volume (to avoid duplicates from user-defined members): - The volume does not exist in the current series members - The series member grouped work permanent ID equals the grouped work permanent id being indexed and does not have a user defined volume OR the grouped work permanent IDs don't match If we go to updating an existing member instead of adding a new one, we will change the userDefinedVolume variable to false if the existing volumes contains the current volume being indexed For deletion, we will no longer remove series members that have a user-defined volume value Update release notes Tested on my local instance of Aspen on individual grouped works and series Will need larger testing batches (nightly index before and after view) to ensure desired series indexing functionality remains
mdnoble73
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new variable "userDefinedVolume" to track whether or not volume information should be overwritten during indexing. Gets set to true if user edits the volume field on an entry Gets set back to false if the user defined value is equal to the value found during indexing
Update GroupedWorkIndexer.java:
The following needs to be true to add a new series member with volume (to avoid duplicates from user-defined members):
If we go to updating an existing member instead of adding a new one, we will change the userDefinedVolume variable to false if the existing volumes contains the current volume being indexed
For deletion, we will no longer remove series members that have a user-defined volume value
Update release notes
Tested on my local instance of Aspen on individual grouped works and series Will need larger testing batches (nightly index before and after view) to ensure desired series indexing functionality remains