Skip to content

DIS-3028 Fix currency formatting with no active language #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdnoble73 merged 1 commit into from
Oct 6, 2026
Merged

DIS-3028 Fix currency formatting with no active language #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions code/web/release_notes/26.10.00/DIS-3028.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Jira: DIS-3028
Type: Bug
Developer: Mark Noble (MDN)
ContributingOrg: Grove For Libraries
Sponsor:
GroveRelease: 26.10.00
CommunityRelease: 26.11.00
Component: Languages and Translations
Description:
- Fix currency formatting when there is no active language (i.e. when running a background task). When this situation occurs, the default language will be used.
NewSettings:
NewPermissions:
15 changes: 14 additions & 1 deletion code/web/sys/Utils/StringUtils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,20 @@ static function getCurrencyFormatter() : NumberFormatter {
$currencyCode = $variables->currencyCode;
}

return new NumberFormatter($activeLanguage->locale . '@currency=' . $currencyCode, NumberFormatter::CURRENCY);
if ($activeLanguage == null) {
require_once ROOT_DIR . '/sys/Translation/Language.php';
$activeLanguage = new Language();
$activeLanguage->isDefault = 1;
if ($activeLanguage->find(true)) {
$locale = $activeLanguage->locale;
}else{
$locale = 'en_US';
}
}else{
$locale = $activeLanguage->locale;
}

return new NumberFormatter($locale . '@currency=' . $currencyCode, NumberFormatter::CURRENCY);
}

static function formatCurrency(float $number) : string {
Expand Down
Loading