Repository navigation
DIS-3002: Prevent delta import from incrementing lastChangeProcessed - #81
Conversation
mdnoble73
left a comment
mdnoble73
left a comment
There was a problem hiding this comment.
Looking great, just a few little fixes
| logEntry.incErrors("Error processing individual record on record " + numRecordsRead + " of " + curBibFile.getAbsolutePath() + " the last record processed was " + lastRecordProcessed + " trying to continue", me); | ||
| } | ||
| if (numRecordsRead % 250 == 0) { | ||
| if (isFullExportFile && numRecordsRead % 250 == 0) { |
There was a problem hiding this comment.
@dd217 Could you update this to save the results even if the full export file is not running? That helps to ensure that it is obvious that the indexer is still running.
There was a problem hiding this comment.
Fixed. I moved the isFullExportFile into a nested if. This way we're not running db updates on a value that never changes.
| logEntry.incRecordsWithInvalidMarc("Error processing record index " + numRecordsRead + " of " + curBibFile.getAbsolutePath() + " the last record processed was " + lastRecordProcessed + " trying to continue" + me); | ||
| } | ||
| if (numRecordsRead % 250 == 0) { | ||
| if (isFullExportFile && numRecordsRead % 250 == 0) { |
There was a problem hiding this comment.
@dd217 Could you update this to save the results even if the full export file is not running? That helps to ensure that it is obvious that the indexer is still running.
There was a problem hiding this comment.
Fixed. I moved the isFullExportFile into a nested if. This way we're not running db updates on a value that never changes.
There was a problem hiding this comment.
@dd217 no need to update the version release file since these yaml files get automatically built in for the advance features
2 participants
This fixes an issue with Symphony and Evolve ILS indexers where delta imports update the lastChangedProcessed. This PR restricts updating lastChangedProcessed only during full imports, and will only reset lastChangedProcessed back to zero if we're processing the current full export.
Testing was performed on a Symphony ILS per the testing documentation listed within the corresponding JIRA. Prairie Lakes does not have a method to test the Evolve ILS indexing code. https://aspen-discovery.atlassian.net/browse/DIS-3002