Skip to content

add system realm permission #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AAndersn wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

add system realm permission #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd6d29
add system realm permission
AAndersn Sep 3, 2026
432f69a
update unit test
AAndersn Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pnnl.goss.core/src/pnnl/goss/core/security/system/SystemBasedRealm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package pnnl.goss.core.security.system;

import java.util.Arrays;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;
Expand Down Expand Up @@ -177,11 +178,10 @@ private synchronized void loadSystemAccount() {
+ "pnnl.goss.security.cfg.");
}

SimpleAccount account = new SimpleAccount(managerUser, managerPassword, getName());
account.addStringPermission(SYSTEM_PERMISSIONS);
Set<String> perms = new HashSet<>(Arrays.asList(SYSTEM_PERMISSIONS.split(",")));

Set<String> perms = new HashSet<>();
perms.add(SYSTEM_PERMISSIONS);
SimpleAccount account = new SimpleAccount(managerUser, managerPassword, getName());
account.addStringPermissions(perms);

userMap.put(managerUser, account);
userPermissions.put(managerUser, perms);
Expand Down
58 changes: 46 additions & 12 deletions pnnl.goss.core/test/pnnl/goss/core/security/system/test/SystemBasedRealmActivationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,27 @@ public class SystemBasedRealmActivationTest {
private static final String SYSTEM_PASSWORD = "manager";

/**
* The exact permission string the broker's authorization plugin consumes for
* the system principal. Deliberately duplicated here as a literal rather than
* referenced from production code: this test is the guard that the string is
* not silently altered.
* The comma-separated permission list configured for the system principal.
* Deliberately duplicated here as a literal rather than referenced from
* production code: this test is the guard that the realm grants exactly these
* permissions and no others.
*
* The realm must split this into individual Shiro permissions
* ({@link #SYSTEM_PERMISSION_SET}). Storing the whole comma-joined string as
* one permission is a bug: Shiro's WildcardPermission treats ',' as
* alternatives within a single ':'-delimited part, so a single
* "queue:*,topic:*,..." permission does not imply the concrete
* "topic:ActiveMQ.Advisory.*:create" permissions the broker checks, and the
* system principal is denied.
*/
private static final String SYSTEM_PERMISSIONS = "queue:*,topic:*,temp-queue:*,fusion:*:read,fusion:*:write";

/**
* The individual permissions the realm must grant, one Shiro permission each.
*/
private static final String[] SYSTEM_PERMISSION_SET = {"queue:*", "topic:*", "temp-queue:*", "fusion:*:read",
"fusion:*:write"};

/** Mutable SecurityConfig stub standing in for SecurityConfigImpl. */
private static final class FakeSecurityConfig implements SecurityConfig {
private String managerUser;
Expand Down Expand Up @@ -124,12 +138,32 @@ public void systemAccountResolvesAfterActivateWithoutShiroInit() throws Exceptio
assertThat(info).isInstanceOf(SimpleAccount.class);
SimpleAccount account = (SimpleAccount) info;
assertThat(account.getStringPermissions())
.as("the system account must carry exactly the broker permission string, unaltered")
.containsExactly(SYSTEM_PERMISSIONS);
.as("the system account must carry each broker permission as a separate Shiro permission")
.containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);

assertThat(realm.getPermissions(SYSTEM_USER))
.as("PermissionAdapter view must report the same split permissions")
.containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);
}

@Test
@DisplayName("The granted permission set is exactly the comma-separated source list, split")
public void grantedPermissionsAreTheSourceListSplit() {
// Guards the split invariant against the source-of-truth string: the set the
// realm grants must be exactly SYSTEM_PERMISSIONS split on ',', with no part
// dropped, merged, or left as the whole joined blob.
assertThat(SYSTEM_PERMISSION_SET)
.as("test's split set must match the configured permission string")
.containsExactlyInAnyOrder(SYSTEM_PERMISSIONS.split(","));

SystemBasedRealm realm = new SystemBasedRealm();
bindSecurityConfig(realm, new FakeSecurityConfig(SYSTEM_USER, SYSTEM_PASSWORD));
realm.activate(componentProperties());

assertThat(realm.getPermissions(SYSTEM_USER))
.as("PermissionAdapter view must report the same single permission string")
.containsExactly(SYSTEM_PERMISSIONS);
.as("the realm must not store the joined string as a single permission")
.doesNotContain(SYSTEM_PERMISSIONS)
.containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);
}

@Test
Expand Down Expand Up @@ -168,7 +202,7 @@ public void shiroInitIsIdempotentAfterActivation() throws Exception {
realm.init();

assertThat(realm.hasIdentifier(SYSTEM_USER)).isTrue();
assertThat(realm.getPermissions(SYSTEM_USER)).containsExactly(SYSTEM_PERMISSIONS);
assertThat(realm.getPermissions(SYSTEM_USER)).containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);
AuthenticationInfo info = realm.getAuthenticationInfo(
new UsernamePasswordToken(SYSTEM_USER, SYSTEM_PASSWORD));
assertThat(info.getPrincipals().getPrimaryPrincipal()).isEqualTo(SYSTEM_USER);
Expand Down Expand Up @@ -213,7 +247,7 @@ public void modifiedDoesNotLeaveStaleAccounts() throws Exception {
.isFalse();
assertThat(realm.getPermissions(SYSTEM_USER)).isEmpty();
assertThat(realm.hasIdentifier("operator")).isTrue();
assertThat(realm.getPermissions("operator")).containsExactly(SYSTEM_PERMISSIONS);
assertThat(realm.getPermissions("operator")).containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);
}

@Test
Expand All @@ -231,7 +265,7 @@ public void rebindReplacesTheSystemAccount() {
.as("greedy rebind must not leave the previous credential source's account behind")
.isFalse();
assertThat(realm.hasIdentifier("operator")).isTrue();
assertThat(realm.getPermissions("operator")).containsExactly(SYSTEM_PERMISSIONS);
assertThat(realm.getPermissions("operator")).containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);

AuthenticationInfo info = realm.getAuthenticationInfo(
new UsernamePasswordToken("operator", "rotated"));
Expand Down Expand Up @@ -351,6 +385,6 @@ public void componentPropertiesAreNotACredentialSource() throws Exception {

assertThat(realm.hasIdentifier(SYSTEM_USER)).isTrue();
assertThat(realm.hasIdentifier("load")).isFalse();
assertThat(realm.getPermissions(SYSTEM_USER)).containsExactly(SYSTEM_PERMISSIONS);
assertThat(realm.getPermissions(SYSTEM_USER)).containsExactlyInAnyOrder(SYSTEM_PERMISSION_SET);
}
}
Loading