Skip to content

Correct usage of Eigenvalue decomposition with ojAlgo #30

Description

@clumsyspeedboat

The current implementation uses Eigenvalue.Generalised<Double> generalisedEvD = Eigenvalue.R064.makeGeneralised(matrix); for eigenvalue decomposition, which is intended for generalised eigenvalue problems. To properly handle symmetric and non-symmetric matrices, update the code to use Eigenvalue.R064.make(matrix, symmetric) (with symmetric set appropriately).

Acceptance Criteria:

  • Code no longer uses makeGeneralised(matrix) unless actually solving a generalised eigenproblem.
  • Use Eigenvalue.R064.make(matrix, true) for symmetric matrices and Eigenvalue.R064.make(matrix, false) for non-symmetric matrices.
  • Add relevant unit tests for both symmetric and non-symmetric cases.

Parent: #29

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions