Skip to content

memorystore: document TOKEN_AUTH as a google-beta-only authorization_mode value#18387

Open
abdalazizmoh wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
abdalazizmoh:memorystore-instance-token-auth
Open

memorystore: document TOKEN_AUTH as a google-beta-only authorization_mode value#18387
abdalazizmoh wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
abdalazizmoh:memorystore-instance-token-auth

Conversation

@abdalazizmoh

Copy link
Copy Markdown

Fixes hashicorp/terraform-provider-google#27309.

authorization_mode on google_memorystore_instance has no client-side enum validation, so this is a documentation-only change to the field's description.

I verified TOKEN_AUTH is currently only accepted by the beta (v1beta) API surface, not GA (v1):

  • gcloud memorystore instances create --authorization-mode=token-auth (GA track) is rejected client-side: Invalid choice: 'token-auth'. Valid choices are [auth-disabled, iam-auth].
  • gcloud beta memorystore instances create --authorization-mode=token-auth (beta track) passes both client-side and server-side validation — a real create request against a test project got all the way to a running operation and only failed on an unrelated (intentionally invalid) network field.

So the description now notes TOKEN_AUTH is only available via the google-beta provider, matching the existing convention for beta-only capabilities documented on otherwise-GA fields (e.g. compute/BackendService.yaml's "Currently self-managed internal load balancing is only available in beta.").

memorystore: documented `TOKEN_AUTH` as a `google-beta`-only value for `authorization_mode` field on `google_memorystore_instance` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2026
@google-cla

google-cla Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from melinath July 24, 2026 13:57
@abdalazizmoh
abdalazizmoh force-pushed the memorystore-instance-token-auth branch from 881cb58 to 37b1b2a Compare July 24, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support TOKEN_AUTH authorization_mode for google_memorystore_instance

2 participants