container: suppress permadiff on private endpoint fields when IP endpoints are disabled#18386
Open
florianmutter wants to merge 2 commits into
Conversation
…oints are disabled When control_plane_endpoints_config.ip_endpoints_config.enabled is false (DNS-only access), the GKE API dictates enable_private_endpoint and master_global_access_config.enabled and ignores writes to them: expandControlPlaneEndpointsConfig returns early without sending either field. flattenPrivateClusterConfig still reads the API's fixed values back into state, so any configured value produced a permanent plan diff that never converged. Suppress the diff on both fields when IP endpoints are disabled, and wire the suppressor onto master_global_access_config.enabled. The suppression logic is extracted into a helper accepting an interface so it can be unit tested with tpgresource.ResourceDiffMock.
modular-magician
added
the
awaiting-approval
florianmutter
marked this pull request as ready for review
July 24, 2026 09:33
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
control_plane_endpoints_config.ip_endpoints_config.enabledisfalse(DNS-only access), the GKE API dictatesprivate_cluster_config.enable_private_endpointandprivate_cluster_config.master_global_access_config.enabledand ignores writes to them: the expander returns early without sending either field. The flattener still reads the API's fixed values back into state, so any configured value produced a permanent plan diff that never converged after apply.This suppresses the diff on both fields when IP endpoints are disabled, and wires the existing private-cluster-config diff suppressor onto
master_global_access_config.enabled. The suppression logic is extracted into a helper accepting an interface so it can be unit tested withtpgresource.ResourceDiffMock.Fixes hashicorp/terraform-provider-google#27901.