Skip to content

update nightly job to Composite and chain sweepers#18382

Open
jackofallops wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
jackofallops:ci/composite-chained-build
Open

update nightly job to Composite and chain sweepers#18382
jackofallops wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
jackofallops:ci/composite-chained-build

Conversation

@jackofallops

@jackofallops jackofallops commented Jul 24, 2026

Copy link
Copy Markdown

Updates the nightly build job to a Composite Job, and chain sweepers to improve reliability and allow build optimisation.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@google-cla

google-cla Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2026
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from c2thorn July 24, 2026 07:39

@c2thorn c2thorn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ERROR] Error while generating TeamCity configs:
[ERROR] Compilation error components/projects/global_sweepers_project.kt[46:9]: Unresolved reference: finishBuildTrigger
[ERROR] Compilation error components/projects/global_sweepers_project.kt[47:13]: Unresolved reference: buildType
[ERROR] Compilation error components/projects/global_sweepers_project.kt[48:13]: Unresolved reference: successfulOnly
[ERROR] Compilation error components/projects/global_sweepers_project.kt[65:9]: Unresolved reference: finishBuildTrigger
[ERROR] Compilation error components/projects/global_sweepers_project.kt[66:13]: Unresolved reference: buildType
[ERROR] Compilation error components/projects/global_sweepers_project.kt[67:13]: Unresolved reference: successfulOnly

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f543c60:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 63 insertions(+), 8 deletions(-)

@BBBmau BBBmau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following up from @c2thorn i applied the changes to validate the build chain, they can be found here

Here's the output that i get when running it with 3 services

How it appears for Service Sweeper with the dependencies set

image image

How it appears for All Nightly Tests

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants