Skip to content

cloudsecuritycompliance: set is_set: true on string array fields in Framework [advanced]#18379

Open
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-cloudsecuritycompliance-framework-set-properties
Open

cloudsecuritycompliance: set is_set: true on string array fields in Framework [advanced]#18379
shuyama1 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix-cloudsecuritycompliance-framework-set-properties

Conversation

@shuyama1

@shuyama1 shuyama1 commented Jul 23, 2026

Copy link
Copy Markdown
Member

Fixes ImportStateVerify attribute mismatch on google_cloud_security_compliance_framework caused by unordered string list returned by the API for supportedEnforcementModes. Added is_set: true to supportedEnforcementModes.

Fixes hashicorp/terraform-provider-google#28394

cloudsecuritycompliance: fixed state drift on `google_cloud_security_compliance_framework` by setting set diff semantics for `supported_enforcement_modes`

@shuyama1 shuyama1 changed the title cloudsecuritycompliance: set is_set: true on string array fields in Framework cloudsecuritycompliance: set is_set: true on string array fields in Framework [advanced] Jul 23, 2026
@modular-magician

modular-magician commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6c1c112:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 24 insertions(+), 8 deletions(-)
google-beta provider View Diff 1 file changed, 24 insertions(+), 8 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field category changed from TypeList to TypeSet on google_cloud_security_compliance_framework - reference
  • Field supported_cloud_providers changed from TypeList to TypeSet on google_cloud_security_compliance_framework - reference
  • Field supported_enforcement_modes changed from TypeList to TypeSet on google_cloud_security_compliance_framework - reference
  • Field supported_target_resource_types changed from TypeList to TypeSet on google_cloud_security_compliance_framework - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
17 17 0 0
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@shuyama1 VCR tests complete for 6c1c112!

@shuyama1
shuyama1 force-pushed the fix-cloudsecuritycompliance-framework-set-properties branch from 6c1c112 to b4cfc54 Compare July 24, 2026 00:05
@modular-magician

modular-magician commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b4cfc54:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 6 insertions(+), 2 deletions(-)
google-beta provider View Diff 1 file changed, 6 insertions(+), 2 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field supported_enforcement_modes changed from TypeList to TypeSet on google_cloud_security_compliance_framework - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
17 17 0 0
Affected Service Packages
  • cloudsecuritycompliance

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@shuyama1 VCR tests complete for b4cfc54!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudSecurityComplianceFramework_cloudsecuritycomplianceFrameworkOrgBasicExample

2 participants