fix: honor per-service defaultUUID for fallback hostnames - #237
Merged
Conversation
getPublicUrl() and the internal hostname/grpc host fallback in DeployableService always used the global default UUID, ignoring a service's own defaultUUID override in lifecycle.yaml. Both now resolve through getUUID(), which already respected the per-service value. Adds unit test coverage for the override.
Adds coverage for the case where the NO_DEFAULT_ENV_RESOLVE feature flag takes priority over a service-level defaultUUID override, for both getPublicUrl() and the deployable hostname/URL fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
defaultUUID(set inlifecycle.yaml) was ignored when building its fallback public URL, internal hostname, and gRPC host — those always fell back to the global default UUID instead.getPublicUrl()and the hostname fallback inDeployableServicenow resolve through the existinggetUUID()helper, which already honored the per-service override.defaultUUID— they still fall back to the global default as before.Verifying Changes