prevent stale PR events from overwriting deploy state - #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delayed synchronize webhook could arrive after a label event and overwrite the PR’s current labels and deployOnUpdate state using stale payload data. This incorrectly disabled subsequent deployments.
This change limits deploy-state updates to PR open, reopen, and close events. Label changes remain owned by the labeled/unlabeled webhook handler, while synchronize and other generic PR events only update metadata.
Regression tests cover delayed synchronize/edited events and preserve reopen and close behavior.