Repository navigation
Expect the intervehicle report on vehicle2's intervehicle layer - #60
Merged
Merged
Conversation
The basic intervehicle harness checked vehicle2 for raw DCCLForwardedData on gobyd's internal modem_data_in group. vehicle2's endpoint is now on the intervehicle layer: as the example's subscriber does, it subscribes to dccl.NavigationReport on the broadcast group from modem 1 and checks the decoded report. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TCmHEtuYatVV6nSaJPTa6z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/intervehicle/basic.test.ymlused to check vehicle2 by looking for rawDCCLForwardedDataon gobyd's internalgoby::middleware::intervehicle::modem_data_ingroup, matching on the DCCL id in the first frame. Now vehicle2's endpoint is aLAYER_INTERVEHICLEendpoint. Like the example's subscriber, it subscribes todccl.NavigationReporton the broadcast group ("0") from modem 1, and the expectation checks the decoded report (z <= 0). vehicle1's check, the outgoing report on its interprocess layer, is unchanged.test/README.md's table entry is updated to match.Dependencies
This uses
goby test's intervehicle endpoints, which are already in goby3's3.0branch. It doesn't depend on thegoby interfacePRs.Test plan
ctest -R goby3_example_test_basic_intervehiclepasses;veh2receives the report across the UDP multicast link.goby3_example_validate_basic_intervehiclepasses.z > 0, the step fails. It received 4 decoded reports and rejected each (z GT 0: got -303), which shows the expectation is checking real reports from vehicle1.Generated by Claude Code