Skip to content

Replace deprecated goby::middleware::SimpleThread - #59

Merged
tsaubergine merged 2 commits into
mainfrom
claude/fervent-wright-atil7p
Nov 12, 2026
Merged

tsaubergine merged 2 commits into
mainfrom
claude/fervent-wright-atil7p

Conversation

@tsaubergine

@tsaubergine tsaubergine commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Fixes the -Wdeprecated-declarations warnings like:

can_example/main.cpp:33:56: warning: 'SimpleThread' is deprecated: Use goby::zeromq::SimpleThread or goby::udpm::SimpleThread instead of goby::middleware::SimpleThread
  • ZeroMQ examples (src/components/middleware/io/{can,cobs,pty,serial,tcp,udp}_example/main.cpp, src/interprocess/zeromq/gps_driver/gps_driver.cpp): these now use goby::zeromq::SimpleThread. The deprecated single-argument goby::middleware::SimpleThread<Config> already derived from SimpleThread<Config, zeromq::detail::InterProcessTag>, so behavior is unchanged.
  • Interthread example (src/interthread/basic_publisher_subscriber/{publisher,subscriber}.h): these now use goby::middleware::StandaloneThread. The app runs under MultiThreadStandaloneApplication and calls only interthread(), so it doesn't need an interprocess layer.

I built this locally against the current goby3 headers. The build was clean, with no C++ warnings. I also ran goby3_example_basic_interthread: both subscribers received the publisher's messages, and it shuts down on SIGINT the same way as before.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj

…SimpleThread

The single-argument middleware::SimpleThread is deprecated and already resolved
to the ZeroMQ implementation tag, so this is behavior-preserving.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj
basic_publisher_subscriber runs under MultiThreadStandaloneApplication and only
uses interthread(), so it has no need for an interprocess layer.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj
@tsaubergine tsaubergine changed the title Replace deprecated goby::middleware::SimpleThread with goby::zeromq::SimpleThread Replace deprecated goby::middleware::SimpleThread Nov 12, 2026
@tsaubergine
tsaubergine merged commit dd8884c into main Nov 12, 2026
5 checks passed
@tsaubergine
tsaubergine deleted the claude/fervent-wright-atil7p branch November 12, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants