Repository navigation
Replace deprecated goby::middleware::SimpleThread - #59
Merged
Merged
Conversation
…SimpleThread The single-argument middleware::SimpleThread is deprecated and already resolved to the ZeroMQ implementation tag, so this is behavior-preserving. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj
basic_publisher_subscriber runs under MultiThreadStandaloneApplication and only uses interthread(), so it has no need for an interprocess layer. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
-Wdeprecated-declarationswarnings like:src/components/middleware/io/{can,cobs,pty,serial,tcp,udp}_example/main.cpp,src/interprocess/zeromq/gps_driver/gps_driver.cpp): these now usegoby::zeromq::SimpleThread. The deprecated single-argumentgoby::middleware::SimpleThread<Config>already derived fromSimpleThread<Config, zeromq::detail::InterProcessTag>, so behavior is unchanged.src/interthread/basic_publisher_subscriber/{publisher,subscriber}.h): these now usegoby::middleware::StandaloneThread. The app runs underMultiThreadStandaloneApplicationand calls onlyinterthread(), so it doesn't need an interprocess layer.I built this locally against the current goby3 headers. The build was clean, with no C++ warnings. I also ran
goby3_example_basic_interthread: both subscribers received the publisher's messages, and it shuts down on SIGINT the same way as before.🤖 Generated with Claude Code
https://claude.ai/code/session_01TCmHEru6z48m7poFR1rEzj