Repository navigation
Mark the examples' essential subscriptions required and validate their deployments - #56
Merged
Merged
Conversation
Merged
5 tasks done
…r deployments The subscriptions these examples cannot work without now say so with Necessity::REQUIRED: the ZeroMQ and UDPM basic subscribers' groups::nav, the JSON subscriber's typed groups::nav, the intervehicle basic subscriber's groups::nav, and both directions of the state machine (state_control into the machine, state_report back to the controller). The state machine controller's placeholder required subscription to groups::gps_control, which nothing publishes, is removed. json_deployment.yml shows a deployment setting a necessity: the JSON subscriber's type-regex subscription is marked recommended there. With export_goby_interfaces and enable_tests, each deployment with a test harness is also checked by 'goby interface validate --strict' as a goby3_example_interfaces_<name> test, so a required subscription left without a publisher fails before anything is launched. This needs a goby that provides goby_validate_interfaces(); with an older one the tests are skipped with a status message. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TCmHEtuYatVV6nSaJPTa6z
tsaubergine
force-pushed
the
use-necessity
branch
from
November 12, 2026 04:56
ef09cf1 to
102319c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Necessity::REQUIRED:groups::navin the ZeroMQ, UDPM and intervehicle basic subscribers;groups::nav;state_controlinto it,state_reportback to the controller).groups::gps_control, which nothing publishes.json_deployment.ymlshows a deployment-level necessity override: it marks the JSON subscriber's type-regex subscriptionrecommended.export_goby_interfaces=ONandenable_tests=ON, each deployment that has a test harness also gets agoby3_example_interfaces_<name>test. It runsgoby interface validate --strict, so a required subscription with no publisher fails before anything is launched.Dependencies
The validation tests need a goby that provides
goby_validate_interfaces()(GobySoft/goby3#448). With an older goby they're skipped with a status message, so the CI build against the current continuous packages is unaffected.Test plan
interface-*branches withexport_goby_interfaces=ON enable_tests=ON. The validate tests pass, and they fail as expected when a required publisher is removed from a deployment.Generated by Claude Code