-
Notifications
You must be signed in to change notification settings - Fork 6
gts-spec v0.14 compliance #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Artifizer
wants to merge
15
commits into
main
Choose a base branch
from
validate-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
45eb503
feat: enforce x-gts-ref existence uniformly for gts-spec v0.14.0
Artifizer 751eeff
fix: validate trait reference constraint types
Artifizer c8ac596
fix(validation): reject unresolved GTS references
Artifizer ca82698
chore: added gts-server to Makefile
Artifizer d921690
fix(validation): validate transitive dependencies
Artifizer fd7b237
test(validation): cover schema reference target failures
Artifizer e5d600c
fix: preserve trait constraints for abstract schemas
Artifizer d0b0034
fix(validation): traverse only schema-valued keywords
Artifizer 265ff2c
fix(traits): suppress required across nested dialects
Artifizer 8a51ad8
fix(validation): resolve relative x-gts-ref dependencies
Artifizer 0d51d0f
fix(validation): traverse Draft 3 schema forms
Artifizer 4ce41ea
fix(validation): defer relative refs in bulk registration
Artifizer b97aa27
fix(validation): traverse array tuple schemas
Artifizer 10a2e7a
feat(x-gts-ref): support configurable validation modes
Artifizer ff052fc
fix(x-gts-ref): bind self references to selected type
Artifizer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| from enum import Enum | ||
|
|
||
|
|
||
| class GtsRefValidationMode(str, Enum): | ||
| NONE = "none" | ||
| PRESENCE = "presence" | ||
| FULL = "full" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: GlobalTypeSystem/gts-python
Length of output: 8147
🤖 get_repo_knowledge executed:
get_repo_knowledge GlobalTypeSystem/gts-python /tmp/coderabbit-repo-knowledge/globaltypesystem-gts-python-c8c06a79/architectureLength of output: 3393
Add a help description for
gts-server.The
helptarget emits a target only when a preceding#line sets its description.gts-serverhas no such comment, somake helpomits it. Add a description comment immediately before the target.🤖 Prompt for AI Agents