Repository navigation
Conversation
DefaultRedirectsService.DeleteById removed the row but, unlike every other write on the service, never raised RedirectsEvents.RedirectsUpdated. The admin redirects list's Delete button calls it, so CustomRedirectHandler kept serving the deleted redirect until the application restarted or another redirect was saved, and OptimizelySyncEvents never relayed the change to other instances. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194 for 6.x. This is the same change as #195, cherry-picked onto
release/v6. Only the CHANGELOG heading needed resolving.DeleteByIdnow raisesRedirectsEvents.RedirectsUpdatedafter the delete, so a redirect deleted from the redirects list stops applying straight away, on every instance.Tests: the same two
DefaultRedirectsServiceTests. Both fail without the fix, andGeta.NotFoundHandler.Testspasses 62/62 on net8.0 with it.🤖 Generated with Claude Code