You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Dangling references to other objects in zarr tests #17
A good chunk of the current zarr cases for v0.6 contain references to objects that aren't there e.g. here where we reference a multiscale at 0/ but we don't have anything there.
I think we want to add these objects right? @clbarnes
I would suggest updating the validate_zarr/*/transforms/* tests to use a Scene rather than a Multiscale because multiscales require adding at least one zarr array, where a Scene doesn't strictly need to actually contain any multiscales so you can get away with just one file.
Hey @DragaDoncila and @clbarnes ! I have capacity to ramp up on fixing these tests this week. However, I'm realizing that I don't quite understand what we need to fix 😬 The OP in this issue seems to be about dangling references in the validate_zarr tests, but the spreadsheet references the parse_attributes tests. Can somebody give me a bit of context/help getting started? Happy to jump on a call if that's easier
At a minimum, every parse_attributes test should have a validate_zarr test, because some tools will only want to operate on whole zarr hierarchies (e.g. in languages with privacy, if the metadata structures are an internal implementation detail - useful when abstracting over multiple versions). So I've listed all the parse_attributes tests to stand in as a list for which validate_zarr tests should exist.
Activity
clbarnes commentedon Oct 1, 2026
Todo list here: https://docs.google.com/spreadsheets/d/1eHHbY0B1_IqIBXAblQFSjY4tRQxd4Mpw9AkFqgss6_M/edit?usp=sharing
Os for todo,Xs for done.clbarnes commentedon Oct 1, 2026
I would suggest updating the
validate_zarr/*/transforms/*tests to use a Scene rather than a Multiscale because multiscales require adding at least one zarr array, where a Scene doesn't strictly need to actually contain any multiscales so you can get away with just one file.kevinyamauchi commentedon Oct 12, 2026
Hey @DragaDoncila and @clbarnes ! I have capacity to ramp up on fixing these tests this week. However, I'm realizing that I don't quite understand what we need to fix 😬 The OP in this issue seems to be about dangling references in the
validate_zarrtests, but the spreadsheet references theparse_attributestests. Can somebody give me a bit of context/help getting started? Happy to jump on a call if that's easierclbarnes commentedon Oct 12, 2026
At a minimum, every parse_attributes test should have a validate_zarr test, because some tools will only want to operate on whole zarr hierarchies (e.g. in languages with privacy, if the metadata structures are an internal implementation detail - useful when abstracting over multiple versions). So I've listed all the parse_attributes tests to stand in as a list for which validate_zarr tests should exist.
kevinyamauchi commentedon Oct 29, 2026
@clbarnes , I think that we can close this now that #48 is merged. What do you think?
kevinyamauchi commentedon Oct 29, 2026
Everything on the spreadsheet is ticked off, so closing this issue. Thanks everyone!