Add reproducible chronological validation support - #157
Open
sergioald wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds reproducible chronological train/validation/test splitting support for time-dependent datasets.
The implementation is designed to make temporal validation explicit, deterministic, replayable, and resistant to accidental leakage across split boundaries.
What is included
datetime64support[start_time, end_time]intervalsReproducibility
ValidationSplitManifestrecords the split definition together with a fingerprint of the ordered temporal coordinates.apply_split_manifest()verifies the fingerprint before reproducing the split, so reordered or changed datasets are rejected rather than silently producing a different validation partition.Scope
This PR intentionally focuses on a small reusable chronological-validation primitive.
It does not add:
Those can be considered separately if useful.
Validation
The implementation was checked locally before submission.
git diff --check: passedNo unrelated changes are included.