Repository navigation
feat(linux): add managed emoji font support - #201
Open
ipproyectosysoluciones wants to merge 2 commits into
Open
ipproyectosysoluciones wants to merge 2 commits into
ipproyectosysoluciones wants to merge 2 commits into
Conversation
- simulator.go: switch isWordChar from byte to rune for UTF-8/emoji - add runeAtBytePos, isEmojiRune, findNextEmoji helpers - update moveWordForward/Backward/EndOfWord for rune boundaries - add simulator_unicode_test.go (ASCII + emoji navigation PASS) - add e2e/test_emoji_navigation.sh - AGENTS.md: link contribution doc Refs: Linux: add managed emoji font support and Unicode rendering configuration
Address the fleet review findings on the emoji/Unicode PR: - moveEndOfWord advanced while the current rune was a word char, so it stopped on the first non-word rune (one past the word), and the trailing adjust block had its condition inverted, never correcting the overshoot. Advance while the next rune is a word char instead and drop the broken adjust block; add regression tests for the review case (hello world), the second-word hop, end-of-line words, and the emoji word case. - isWordCharForTextObj built a string from a single byte value, which re-encoded the byte as a code point instead of decoding the original UTF-8 stream, making its multi-byte handling a no-op. Pass the source line plus byte offset so text objects classify real runes. - The emoji navigation E2E script hardcoded an absolute path from the author's machine and printed PASS unconditionally (it even reported a helper that never existed). Use a repo-relative path, assert the helpers that the feature actually ships, and exit non-zero on failure.
Author
|
Both findings from the deepseek review are fixed in 90a0b9a:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #200 (status: needs-review / enhancement).
Adds managed emoji font support and Unicode rendering configuration to the Vim trainer simulator (simulator.go) for Linux multi-byte UTF-8 input.
Changes:
Build: go clean. Tests: PASS.
Label intended: type:feature (not present in upstream repo; suggest adding).