Close three pre-relaunch gates: pytest scope, licensing catch-all, conformance attestation - #55
Merged
Merged
Conversation
The site build depends on a bare `uv run pytest -v` running in the environment uv.lock produces. With no testpaths, pytest collects the whole repository, so any suite whose dependencies sit outside the lockfile fails at collection and takes the deploy down with it. PR #22 adds 23 adapter test files needing rfc8785, nvidia-nat-core, and ruamel, none of them locked: against a merged tree that is 22 collection errors and an interrupted run, which fails the test job and stops the build job that depends on it. Scoping collection to tests/ keeps the deploy gate about the guards it was written for. Suites carrying their own dependencies run from their own workflow, which is what adapter_tests.yml already does. CONTRIBUTING now says where guards live and why a test written elsewhere never runs, since that silence is what let both contributors build suites CI would not have executed. Signed-off-by: rocklambros <[email protected]>
The table mapped ten specific paths and stopped, so a new top-level directory arrived governed by nothing until someone noticed it was unlisted. The adapters/ directory in PR #22 is the next one due to land. Apache 2.0 is the default because a new directory is usually code, and an over-permissive grant on prose costs less than a ShareAlike obligation attaching by accident to reference code adopters copy into their own systems. A prose directory still wants its own explicit CC-BY-SA-4.0 row. Signed-off-by: rocklambros <[email protected]>
Nobody does, in v0.1.0. profiles_supported and profiles_accepted are self-declaration on the wire, and the release ships no conformance suite, no registry, and no steward to arbitrate a disputed claim. The page described what the label guarantees without saying that the label is the implementer's own assertion, which is the gap issue #19 raised against a standard that markets itself as a control standard rather than a wire format. The paragraph sits below the ACS-Core requirement list rather than inside it, so the line numbers PR #22's citation guard pins do not move. Signed-off-by: rocklambros <[email protected]>
rocklambros
requested review from
GangGreenTemperTatum,
afogel,
almogbhl,
bar-capsule,
fewdisc,
mamicidal,
sclintonowasp and
stefanoamorelli
as code owners
September 6, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three pre-relaunch gates, each independently revertable.
Scope pytest collection to
tests/. The site build depends on a bareuv run pytest -vrunning in the environmentuv.lockproduces. With notestpaths, pytest collects the whole repository, so a suite whose dependencies sit outside the lockfile fails at collection and takes the deploy with it. PR #22 adds 23 adapter test files needingrfc8785,nvidia-nat-core, andruamel, none of them locked. Measured against a real merged tree:pyproject.tomlInterrupted collection exits nonzero, which fails the
testjob, which stops thebuildjob that declaresneeds: test. Onmainas it stands today the change is inert: 194 passed and 1 skipped both with and without it, because nothing currently lives outsidetests/.CONTRIBUTING now says where guards belong and why a test written elsewhere never runs. That silence is what let two contributors build suites CI would not have executed.
Give
LICENSING.mda catch-all row. The table mapped ten paths and stopped, so a new top-level directory arrived governed by nothing until someone noticed.adapters/is the next one due. Apache 2.0 is the default because a new directory is usually code, and an over-permissive grant on prose costs less than a ShareAlike obligation attaching by accident to reference code that adopters copy into their own systems. A prose directory still wants its own explicitCC-BY-SA-4.0row.Say who verifies an ACS-Core conformance claim. Nobody does, in v0.1.0.
profiles_supportedandprofiles_acceptedare self-declaration on the wire, and this release ships no conformance suite, no registry, and no steward to arbitrate a disputed claim. The page described what the label guarantees without saying the label is the implementer's own assertion, which is the gap issue #19 raised. The paragraph sits below the ACS-Core requirement list rather than inside it, so theconformance.mdline numbers PR #22's citation guard pins do not move.Closes part of #19.