[MEDIUM] fix(android): detect enabled legacy mock locations - #367
Open
OskarEichler wants to merge 1 commit into
Open
[MEDIUM] fix(android): detect enabled legacy mock locations#367OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1as mock locations enabled0) and missing values falseSecurity impact
On Android versions before API 23,
Settings.Secure.ALLOW_MOCK_LOCATIONuses1for enabled and0for disabled. The current comparison is inverted, so a device with mock locations enabled is reported as safe while a device with the setting disabled is reported as capable of mocking location. Applications usingcanMockLocation()ortrustFall()as a risk signal therefore receive a false negative on Android 5.x.Verification
:jail-monkey:testDebugUnitTest: 1 test passed:jail-monkey:compileDebugJavaWithJavac: passedgit diff --check: passedThis PR contains only the legacy-setting inversion fix and its regression coverage.