Repository navigation
Fix token extraction in SharePage with await params - #16
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the 'SharePage' component to treat 'params' as a Promise and await its resolution, aligning with newer Next.js APIs. It also modifies the auto-generated 'next-env.d.ts' file. The reviewer recommends reverting the change to 'next-env.d.ts' to prevent unnecessary git churn, as this file is automatically managed by Next.js.
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| import "./.next/dev/types/routes.d.ts"; | ||
| import "./.next/types/routes.d.ts"; |
There was a problem hiding this comment.
The file next-env.d.ts is auto-generated and maintained by Next.js. The change from ./.next/dev/types/routes.d.ts to ./.next/types/routes.d.ts occurs automatically depending on whether a development server (next dev) or a production build (next build) was run. Committing this change will cause unnecessary git churn for other developers when they run their local development server, as Next.js will automatically rewrite this file. It is recommended to revert this change to keep the repository clean.
| import "./.next/types/routes.d.ts"; | |
| import "./.next/dev/types/routes.d.ts"; |
No description provided.