Skip to content

Fix token extraction in SharePage with await params - #16

Merged
GamingOP69 merged 2 commits into
GamingOP69:mainfrom
Sarika-Kafle:main
May 31, 2026
Merged

GamingOP69 merged 2 commits into
GamingOP69:mainfrom
Sarika-Kafle:main

Conversation

@Sarika-Kafle

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 31, 2026 16:57
@GamingOP69
GamingOP69 merged commit 4bd825b into GamingOP69:main May 31, 2026
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'SharePage' component to treat 'params' as a Promise and await its resolution, aligning with newer Next.js APIs. It also modifies the auto-generated 'next-env.d.ts' file. The reviewer recommends reverting the change to 'next-env.d.ts' to prevent unnecessary git churn, as this file is automatically managed by Next.js.

Comment thread next-env.d.ts
/// <reference types="next" />
/// <reference types="next/image-types/global" />
import "./.next/dev/types/routes.d.ts";
import "./.next/types/routes.d.ts";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file next-env.d.ts is auto-generated and maintained by Next.js. The change from ./.next/dev/types/routes.d.ts to ./.next/types/routes.d.ts occurs automatically depending on whether a development server (next dev) or a production build (next build) was run. Committing this change will cause unnecessary git churn for other developers when they run their local development server, as Next.js will automatically rewrite this file. It is recommended to revert this change to keep the repository clean.

Suggested change
import "./.next/types/routes.d.ts";
import "./.next/dev/types/routes.d.ts";

@Sarika-Kafle
Sarika-Kafle removed the request for review from Copilot May 31, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants