Repository navigation
Fix: Refuse to mint an NFT whose instance number already exists - #943
Merged
Merged
Conversation
Before saving new NFT instances, mintToken checks that none of their keys is already on the ledger and throws NftInstanceAlreadyExistsError if one is, so a mint can never overwrite an existing NFT. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before saving new NFT instances,
mintTokenchecks that none of their keys is already on the ledger. If one exists, the mint fails withNftInstanceAlreadyExistsErrorand nothing is written, so a mint can never overwrite an existing NFT. This adds one state read per minted NFT.