Repository navigation
Fix: Mint from the larger supply, count every mint allowance grant, init name check, remove high-throughput leftovers - #942
Merged
Conversation
…uests A token class minted through the removed high-throughput flow can have a total behind its mint request records. A mint now saves the larger of the two on the token class before adding its quantity, so a new NFT never reuses an existing instance number. The supply read uses the same larger number. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Mint allowance requests to the same user in one transaction share a key, whoever grants them. The second grant now adds its quantity to the request already written instead of overwriting it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Remove HighThroughputMintTokenDto, FulfillMintDto, the HighThroughputMint fee gate codes, the unused fulfillment helpers on mint requests, and the outdated TransferTokenDto description. Co-Authored-By: Claude Opus 5.5 <[email protected]>
A multiplicative tier now charges baseQuantity * ((chargeableUses + 1) * feeAccelerationRate), so the use at the threshold costs baseQuantity * feeAccelerationRate and each later use costs one step more. No fee definition on mainnet uses the multiplicative type. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readMintSupply), saves it on the token class, then adds its quantity. A class minted through the removed high-throughput flow can have a total behind its request records; without this a new NFT could reuse an existing instance number.FetchTokenClassesWithSupplyreports the same number.CreateVestingTokenrelies on several grants to the admin in one transaction, so a later grant is accumulated rather than rejected..leaves no files behind.HighThroughputMintTokenDto,FulfillMintDto, theHighThroughputMint*fee gate codes, the unused fulfillment helpers on mint requests, and the outdatedTransferTokenDtodescription.baseQuantity × ((chargeableUses + 1) × feeAccelerationRate), so the threshold use costsbaseQuantity × feeAccelerationRateand each later use one step more. No fee definition on mainnet uses this type (checked in query-apiallChainObjects, indexGCFD).