Repository navigation
Fix: NFT vesting locks, per-owner mint fulfillments, and network root in .dockerignore - #941
Merged
Merged
Conversation
A fungible vesting hold already released its quantity at the vesting start. An NFT with the same hold stayed locked, because the instance lock check ignored the vesting start. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Mints to different owners in one transaction now write separate fulfillment records under their own keys, so each record can be read back by its key. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ckerignore The network root holds network crypto material. When it sits inside a chaincode directory, it must be listed in that directory's .dockerignore, so the material does not reach the chaincode image build. The fabloRoot flag description now states the actual rule. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
owneris now part of theTokenMintFulfillmentkey. Mints to different owners in one transaction write separate records, each readable by its own key, and the rawputStateworkaround is gone. Two mints to the same owner still add up into one record. No code reads fulfillments other than this write path. For a second owner, the new key matches the key the workaround used..dockerignore.network-uprejects a network root inside a chaincode directory unless that directory's.dockerignorelists it, so network crypto material does not reach the chaincode image build. The template already liststest-network. ThefabloRootflag description and the README now state the actual rule.