Repository navigation
rldb: rename source_recording_id to vendor_recording_id - #740
Merged
Merged
Conversation
Lance already stores this ID as recordings.vendor_recording_id, the input to the recording_id hash; one name across zarr attrs, MCAP and Lance. Claude-Session: https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the
source_recording_idthat #736 introduced tovendor_recording_id, the name Lance already uses for the same ID (recordings.vendor_recording_id, the input to therecording_idhash). One name across zarr attrs, the MCAP spec and Lance.ZarrWriter/create_and_writeargument, the stored zarr attr, the zarr and MCAP validators,required_metadata.py, the aria/eva/mecka converters, the vendor template,SPEC.md,CONTRIBUTING_DATA.md,INTERNAL_DATA.mdand tests.Rollout
Zarr episodes written since #736 merged carry
source_recording_id; the validator now expectsvendor_recording_id. If any were written, rename the attr on them or rewrite them.Testing
On a compute node:
test_zarr_required_metadata,test_mcap_validate(224 passed, 1 skipped),test_run_conversion_metadata,test_convert_template,test_packagingandtest_synthetic_episodespass.https://claude.ai/code/session_01HjCQBqQCr2igFEMR7yUovw