Repository navigation
Conversation
- hdf5_to_zarr.py imports a module that no longer exists and uses the removed write_incremental path. - The dataset/embodiment tutorial notebooks are stale; the README points to the converter template instead. - Cover a child-only rewrite in the norm-cache fingerprint tests, since write_annotations now also rewrites the root zarr.json. Claude-Session: https://claude.ai/code/session_01QY8Web4qc6ZYYrAAdw6TTa
RyanPCo
changed the base branch from
ryanco/zarr-converter-validation
to
main
October 23, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #736. Not for merge yet. This is cleanup split out of #736 so that PR only carries the raw format and converter validation.
egomimic/rldb/zarr/hdf5_to_zarr.py. It was already unimportable on main because it imports the missingegomimic.scripts.eva_process.zarr_utils, and it relies on thewrite_incrementalpath that Require zarr episode metadata; add zarr/MCAP validators and vendor converter template #736 removes. Coordinate with Jmni/zarr validation #607, jmni/zarr_registry #600 and fix(zarr): repair an unresolvable import, and share two copy-pasted helpers #565, which edit this file.dataset_tutorial.ipynbandembodiment_tutorial.ipynb. The README now points to the converter template.test_episode_fingerprint_sees_a_child_only_rewrite. Sincewrite_annotationsalso rewrites the rootzarr.json, the annotation test no longer covers a rewrite that touches only a child array.test_norm_cache.py.Testing
tests/unit/test_norm_cache.pypasses (15 tests, CPU-only on a compute node).https://claude.ai/code/session_01QY8Web4qc6ZYYrAAdw6TTa