Repository navigation
fix fault buffer clipper tests - #635
Merged
Merged
Conversation
…ared against the wrong files. I don't know why it passed in places
…ly shallow so it's quite obvious if 3d distance filter is working
…with sconv to get accurate results fault to fault
…test made w/ help from chatgpt
CB-quakemodel
approved these changes
Oct 30, 2026
CB-quakemodel
left a comment
CB-quakemodel
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks Kendra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were broken for the function that clips the mfds of point sources within a fault buffer. They were broken locally but not being flagged in CI. However, the test results (even pass / fail) changes depending on who runs locally among me, @CB-quakemodel and @kirstybayliss. This PR is WIP until we resolve that.
The tests failed locally because the output files were not updated with some of the latest (2024) fixes to the clipper itself. The reference test files have been updated accordingly. In addition, this PR does the following:
rupture_mesh_spacinginremove_buffer_around_faultsfrom 5.0 to 1.0. This is necessary so that both simpleFaults and multiFaultSources with identical geometry give the same results, and because we want more accuraterrupwhen identifying point sources within the fault buffer.