fix(build): add --ignoreConfig for TypeScript 7 to prevent TS5112 - #149
Merged
Merged
Conversation
TS 7 (Go rewrite) errors with TS5112 when a file is passed on the command line and a tsconfig.json is present in the CWD. [email protected] (bundled in 2.5.2-beta.1) brings TypeScript 7 in as a transitive dependency, so any consumer project with a tsconfig.json will hit this error without the flag. Our defaultTscBuildFlags already controls all compiler options explicitly, so ignoring any ambient tsconfig is correct behaviour.
…irect file arg Covers the exact trigger the --ignoreConfig fix guards: a .ts input passed directly on the CLI with a tsconfig.json present in the CWD. The prior matrix omitted this combination, so the fix could have been silently dropped without a test failure.
…dk-js into fix/security-hardening
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regression test must pin TypeScript 7 to reliably exercise the TS5112 code path.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
… test to version matrix TS5112 (ambient tsconfig.json + CLI file arg) is triggered by TS 6.0.0-beta as well as TS 7; the previous major >= 7 condition was too narrow. The regression case is moved from fastedge-build.test.js (unpinned npm install) into typescript-versions.test.js so it runs against every pinned major in the matrix. The unpinned variant is removed.
|
🎉 This PR is included in version 2.5.2-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS 7 (Go rewrite) errors with TS5112 when a file is passed on the command line and a tsconfig.json is present in the CWD. [email protected] (bundled in 2.5.2-beta.1) brings TypeScript 7 in as a transitive dependency, so any consumer project with a tsconfig.json will hit this error without the flag.
Our defaultTscBuildFlags already controls all compiler options explicitly, so ignoring any ambient tsconfig is correct behaviour.