Fix/security advisories - #48
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Strip API key from process.env after capture so build subprocesses (cargo build.rs, npm lifecycle scripts, proc-macros) cannot read it - Add buildSubprocessEnv() allowlist for all spawn sites; thread gcoreApiKey explicitly to gcore_api and batch_execute tools - Add timeout (180s JS/AS, 300s Rust) and 10MB output cap to all compiler spawn paths to prevent unbounded hang/memory DoS - Fix normalizePath to resolve symlinks via realpathSync so a workspace symlink cannot escape the workspace root - Pin create-fastedge-app to an exact version; force registry and userconfig for scaffold invocations to block .npmrc redirect attacks - Replace world-writable chmod 777 walk with chownSync to workspace owner; bound directory walk to workspaceRoot (not cwd) - Add baked fastedge user (UID 10001) to base image; redirect root fallback in entrypoint to that user instead of staying root - Remove unused qs direct dependency; add pnpm overrides for all vulnerable transitive deps (zero prod advisories after) security audit of mcp-server add pr-test CI/CD remove internal security advisory context from public repo Audit docs moved to fastedge-coordinator/context/security-advisories/ so they do not ship to users of this public package.
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
godronus
force-pushed
the
fix/security-advisories
branch
from
September 9, 2026 09:08
096cec5 to
f84ba08
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
normalizePath() returning a realpath-rooted prefix can break callers that compare against the original workspaceRoot string (notably build-root discovery) when workspaceRoot is a symlink.
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
src/utils/index.ts:34
- normalizePath currently returns paths rooted at realpathSync(workspaceRoot) (via
candidate = path.join(rootReal, ...)). If workspaceRoot itself is a symlink, callers that compare against the original workspaceRoot string (e.g. deriveBuildDirectory’sdir.startsWith(path.resolve(workspaceRoot))in src/tools/local/workspace/compiler/index.ts) will stop working because entryFilePath no longer shares the same lexical prefix. Consider using real paths only for the confinement checks, but returning a path rooted at the caller-provided workspaceRoot.
- Files reviewed: 28/29 changed files
- Comments generated: 0 new
- Review effort level: Lite
NOT AN ISSUE: Not worth a fix: — The threat model is "malicious workspace must not escape confinement." Here, the confinement check inside normalizePath is still correct (rootReal vs probeReal). The only thing that breaks is that callers like deriveBuildDirectory get back a realpath-rooted string that doesn't match their workspaceRoot prefix — so a build might fail or misroute, not escape the workspace.
godronus
force-pushed
the
fix/security-advisories
branch
from
September 9, 2026 12:18
fe4f1de to
e31a32b
Compare
qrdl
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.