Added new template param types - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenAPI schemas and regenerates the Go SDK models, expanding the supported API surface (including new template parameter types and new edge-store/statistics models).
Changes:
- Expanded
template_param.data_typeenum (addsstore,bool,json,enum) and introducedmetadata. - Added multiple new schemas/models (e.g., edge stores, encoded values, admin stats) and refined many existing schema constraints/descriptions.
- Regenerated
sdk-schemas.gen.gowith oapi-codegen v2.5.1, adding new union helpers for store entry payloads.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 11 comments.
| File | Description |
|---|---|
| sdk-schemas.gen.go | Regenerated Go models/types (plus new union helpers) based on updated OpenAPI schema. |
| schemas.yml | Updated OpenAPI component schemas (new types, enum expansions, constraints, and documentation updates). |
Files not reviewed (1)
- sdk-schemas.gen.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
86
to
+90
| type: string | ||
| description: App name | ||
| description: Unique application name (alphanumeric, hyphens allowed) | ||
| minLength: 1 | ||
| maxLength: 64 | ||
| pattern: "^[a-z0-9][a-z0-9-]*[a-z0-9]$" |
Comment on lines
1
to
4
| // Package sdk provides primitives to interact with the openapi HTTP API. | ||
| // | ||
| // Code generated by github.com/oapi-codegen/oapi-codegen/v2 version v2.4.1 DO NOT EDIT. | ||
| // Code generated by github.com/oapi-codegen/oapi-codegen/v2 version v2.5.1 DO NOT EDIT. | ||
| package sdk |
Comment on lines
+855
to
+864
| func (t *StoreEntry_Payload) MergeStoreKvPairValue(v StoreKvPairValue) error { | ||
| b, err := json.Marshal(v) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| merged, err := runtime.JSONMerge(t.union, b) | ||
| t.union = merged | ||
| return err | ||
| } |
Comment on lines
+874
to
+878
| func (t *StoreEntry_Payload) FromStoreSortedSet(v StoreSortedSet) error { | ||
| b, err := json.Marshal(v) | ||
| t.union = b | ||
| return err | ||
| } |
Comment on lines
+881
to
+890
| func (t *StoreEntry_Payload) MergeStoreSortedSet(v StoreSortedSet) error { | ||
| b, err := json.Marshal(v) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| merged, err := runtime.JSONMerge(t.union, b) | ||
| t.union = merged | ||
| return err | ||
| } |
Comment on lines
+907
to
+916
| func (t *StoreEntry_Payload) MergeStoreBloomFilter(v StoreBloomFilter) error { | ||
| b, err := json.Marshal(v) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| merged, err := runtime.JSONMerge(t.union, b) | ||
| t.union = merged | ||
| return err | ||
| } |
Comment on lines
+848
to
+852
| func (t *StoreEntry_Payload) FromStoreKvPairValue(v StoreKvPairValue) error { | ||
| b, err := json.Marshal(v) | ||
| t.union = b | ||
| return err | ||
| } |
| description: "The unique name of the secret." | ||
| minLength: 1 | ||
| maxLength: 128 | ||
| pattern: "^[a-zA-Z0-9][a-zA-Z0-9_-]*[a-zA-Z0-9]$" |
| description: Network name | ||
| minLength: 1 | ||
| maxLength: 64 | ||
| pattern: "^[a-z0-9][a-z0-9_-]*[a-z0-9]$" |
| description: Unique plan identifier (alphanumeric and hyphens) | ||
| minLength: 1 | ||
| maxLength: 64 | ||
| pattern: "^[a-zA-Z0-9][a-zA-Z0-9-]*[a-zA-Z0-9]$" |
ruslanti
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.