Skip to content

👷 Use mise.toml as node-version-file for setup-node - #287

Merged
Friedinger merged 1 commit into
mainfrom
ci/setup-node-version-file
Oct 18, 2026
Merged

Friedinger merged 1 commit into
mainfrom
ci/setup-node-version-file

Conversation

@Friedinger

@Friedinger Friedinger commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

The Node.js version is now maintained only in mise.toml. actions/setup-node reads it via node-version-file, so the duplicate node-version entry in the workflows is gone.

@github-actions github-actions Bot added the 👷 CI/CD Changes related to continuous integration/deployment label Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8f9bff08-81a5-49cb-9e52-ae8cf9bb0857
📥 Commits

Reviewing files that changed from the base of the PR and between 9cf2935 and b643d24.

📒 Files selected for processing: 2
  • .github/workflows/build-test.yml
  • .github/workflows/release.yml

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f613e8a4-d5f9-4835-93a8-a84302d29ce1
📥 Commits

Reviewing files that changed from the base of the PR and between bafaa0b and 9cf2935.

📒 Files selected for processing: 2
  • .github/workflows/build-test.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Both the build-test and release workflows now read the Node.js version from mise.toml instead of specifying 24.21.0 directly.

Changes

Workflow Node.js Version Source

Layer / File(s) Summary
Use mise.toml for Node.js setup
.github/workflows/build-test.yml, .github/workflows/release.yml
Both workflows now use the Node.js version specified in mise.toml.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 9cf29

Both workflows continue to use Node.js 24.21.0 from mise.toml, with no identified workflow-blocking risk. The change is ready to merge subject to normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description accurately explains that both workflows now read the Node.js version from mise.toml through actions/setup-node and remove duplicate version entries.
Title check Passed The title clearly identifies the main change: using mise.toml as the node-version-file for actions/setup-node.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow trail
Two scripts now read the same version
From mise.toml, Node takes its cue
No pinned number sits in view
The rabbit hops along, content and true

Comment @coderabbitai help to get the list of available commands.

@Friedinger
Friedinger force-pushed the ci/setup-node-version-file branch from f0677fe to 9cf2935 Compare October 18, 2026 08:41
@Friedinger Friedinger changed the title ci: use mise.toml as node-version-file for setup-node 👷 Use mise.toml as node-version-file for setup-node Oct 18, 2026
@Friedinger
Friedinger force-pushed the ci/setup-node-version-file branch from 9cf2935 to b643d24 Compare October 18, 2026 08:45
@Friedinger
Friedinger merged commit 7bd64c0 into main Oct 18, 2026
11 checks passed
@Friedinger
Friedinger deleted the ci/setup-node-version-file branch October 18, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷 CI/CD Changes related to continuous integration/deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant