Repository navigation
chore(deps): resolve Dependabot #110, #115, #116 (dev-tooling transitive deps) - #982
Merged
Merged
Conversation
Override http-cache-semantics to ^4.3.0, katex to ^0.18.2 and smol-toml to ^1.9.0 so the resolved tree clears Dependabot alerts #110, #115 and #116 (CVE-2026-93748, CVE-2026-103923, GHSA-r4xh-jqrq-34v2). All three arrive only through dev tooling (the electron-builder download path and markdownlint-cli2) and none ship in the desktop package or the runtime servers. Effect on FloCafe is limited to npm run docs:check and packaging; the katex jump stays inside 0.18.x to keep the range micromark-extension-math expects. sprintf-js (alert #117) has no patched release upstream, so it is left for a Dependabot dismissal.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins three transitive devDependencies to their patched releases via npm
overrides, resolving Dependabot alerts #110, #115 and #116.http-cache-semantics<= 4.2.04.3.0electron-builder->app-builder-lib->@electron/get->got->cacheable-requestkatex>= 0.11.0, < 0.18.20.18.10markdownlint-cli2->markdownlint->micromark-extension-mathsmol-toml<= 1.8.01.9.0markdownlint-cli2Impact on FloCafe
None of these packages ships in the desktop package, the frontend export, or the runtime servers. All three are pull-only on
electron-builder(Electron binary download during packaging) andmarkdownlint-cli2(docs lint), so the only affected local commands arenpm run docs:checkand packaging. No production code path changes.http-cache-semanticsis already allowed bycacheable-request(^4.0.0); it is overridden anyway so the resolved version is deterministic rather than left to the lockfile.katexis held at^0.18.2(not 0.19.x) to keep the change conservative.Verification
npm ls http-cache-semantics katex smol-toml sprintf-js-> clean, exit 0npm audit-> no longer reportshttp-cache-semantics,katexorsmol-tomlnpm ci(root) -> lockfile in sync, exit 0npm ci(frontend) +npm run lint-> 0 errorsnpm run docs:check-> 52 files, 0 issues; links, index and policy checks OKnpm run build-> passRemaining alert
Alert #117 (
sprintf-js, medium, CVE-2026-97058) is not addressed: no patched release exists upstream (1.1.3 is the latest), and forcing@electron/getto a version that dropsglobal-agentbreakselectron-builderat load time (ESM vs CJS). Recommend dismissing it in Dependabot as tolerable risk / vulnerable code not used, since its only format strings are static literals in build tooling.