send ghosts with no information for a frame 'far' away - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ghosts "disappear" on frames for which they have no data, rather than showing stale (and thus sometimes garbage) data, by sending them to the (30000, 30000, 30000) coordinate, which is unlikely to ever be observed in-game.
This method is workaround for #67, which currently prevents STROOP from simply not requesting the hack to render the ghosts at all. It also avoids the necessity to make a design decision regarding the white "debug ghost" that shows when no "actual" ghosts are currently shown, which the approach of not requesting any ghosts at all would perhaps fall under.