feat(DataRetentionSettingsForm): per-store data retention settings element - #244
Open
brettflorio wants to merge 3 commits into
Open
feat(DataRetentionSettingsForm): per-store data retention settings element#244brettflorio wants to merge 3 commits into
brettflorio wants to merge 3 commits into
Conversation
…ement foxy-data-retention-settings-form edits fx:data_retention_settings: a toggle (auto_anonymize) and a conditional days-of-inactivity field with a 90-day minimum (v8n + min). Mirrors CustomerPortalSettingsForm (PATCH-only settings singleton: delete/timestamps hidden). Includes i18n, tests, and a story. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
…dataset Populated fixture + store link so the storybook Playground loads an editable data_retention_settings resource. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Brett Florio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
Brett Florio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…field data_retention now lives on the Store resource (not a sub-resource), so the form binds to a store and edits the nested data_retention object via custom get/set + this.edit() (the StoreForm pattern). Update v8n/hiddenSelector to read data_retention.*, stories to a store href, and tests. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01UGvyb3Yx7kGiTWfaVnBa4u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataRetentionSettingsForm — edits the store's
data_retentionfielddata_retentionnow lives on the Store resource (not adata_retention_settingssub-resource), so the form is Store-typed and edits the nesteddata_retentionobject via customgetValue/setValue+this.edit()(theStoreFormnested-JSON-field pattern).auto_anonymize(switch) +auto_anonymize_days(number, min 90); v8n andhiddenSelectorreaddata_retention.*; days control hidden unless auto-anonymize is on.data_retentioncase). Suite green.Requires the foxy-sdk change adding
data_retentionto the Store graph.