Repository navigation
Add support for viewing and deleting invalid actions - #2501
Open
CarlosFdez wants to merge 1 commit into
Open
CarlosFdez wants to merge 1 commit into
CarlosFdez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds invalid actions to the list of actions and makes them delete-able. I ran into this in the wild with the "undead adversaries" module on the spectral assassin creature, when I attempted to retier it for tier 2 and ran into an error. There was an action of type ability in there fsr, maybe due to a very old bug.
We could do the same for effects, but getting a test case will be tricky. Its easy enough to get a test case for invalid items (I think either ikonis/beast feast modules add a new item type), but I don't know where exactly to show invalid items in the sheet.