Skip to content

Make the protective feature configurable - #2489

Merged
CarlosFdez merged 3 commits into
feature/versatilefrom
feature/protective
Oct 16, 2026
Merged

CarlosFdez merged 3 commits into
feature/versatilefrom
feature/protective

Conversation

@CarlosFdez

Copy link
Copy Markdown
Contributor

Will add migration and SRD updates after this is confirmed good. This adds support for weapons with a protective value of 1.

@CarlosFdez
CarlosFdez added this pull request to stack #2490 October 16, 2026 05:04
@WBHarry

WBHarry commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Testing this, it works, but there is an undesireable thing. Might not really be easily fixeable, haven't really thought about it yet, but:

This workflow:

  • Make a new weapon on a character
  • Equip it
  • Add Protective
  • The default @item.tier value is not added to the armor score
  • Edit something --> The armor score updates and works

@CarlosFdez

Copy link
Copy Markdown
Contributor Author

Still waking up. I'll look into it. Good catch.

@WBHarry WBHarry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CarlosFdez
CarlosFdez merged commit 0c790f2 into main Oct 16, 2026
1 check passed
@CarlosFdez
CarlosFdez deleted the feature/protective branch October 16, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants