[CarlosFdez]

No description provided.

[WBHarry]

Looks good. I did some testing, and found one issue.
The damage formula split based on Hope/Fear doesn't work in this branch - I tested, and it works on main.

[CarlosFdez]

Thanks for helping me test, it was not fully tested yet. This means I should focus my attention on hope/fear split.

Hope/fear splits work when damage automation is set to never on main, but fails in all other cases, so the entire thing was already quite fragile.

[CarlosFdez]

I fixed the regression. The error with hope/fear results when damage autoroll is enabled still persists, but after digging into it it seems the issue is that the damage split results relies on config.roll being the actual roll itself. In the case of the damage autoroll, its a plain object. So its likely something that'll be fixable once we refactor the roll parts of it (which I have no idea what to do there yet).

[CarlosFdez]

The diff will reduce if the movement of ResourceUpdateMap and character sheet types moves into a new PR, and then this gets rebased on top. Let me do that separately, since a smaller diff will make a project of this complexity easier to deal with.

PR here #2442

[WBHarry]

I made a fix for deathmoves, can check the thing I changed in the commit.

---

Found two issues that I'm not sure about atm.

1. Tested Rain of Blades domain card action, and it generates 2 chat messages now. It should only create the initial roll message.

2. Damage rolls are failing. The config's this.item ends up set as the Actor data. Actor data isn't item though, so it crashes on checks that happen.

[CarlosFdez]

Can you tell me what damage roll is failing? They're working for me, so its probably a specific scenario. That or I accidentally fixed it.