Skip to content

Template: fold the salvageable sections from the root-template proposal into the main template - #7

Merged
orda-aska merged 2 commits into
mainfrom
template-salvage-from-pr2
Oct 27, 2026
Merged

orda-aska merged 2 commits into
mainfrom
template-salvage-from-pr2

Conversation

@orda-aska

Copy link
Copy Markdown
Contributor

Folds the salvageable sections from the root-template proposal into the main pull request template, instead of merging that proposal as a root file it would never be used from.

Root cause

The main template had no place for a fix mechanism, a before/after check table, a claim label, or a disclosure. The root-template proposal had all four, but GitHub reads the template in the .github folder before the root, so the root file would have been shadowed.

Changes

  • .github/pull_request_template.md: Root cause, a before/after table under How it was checked with a Not covered line, Prior art and claim label, Disclosure, and the standing oversight line.
  • The tick-box sections are unchanged, so the triage bot reads them as before.
  • Dropped from the proposal: title guidance, lede, per-file change bullets, credits, and left-out items.

Validation

Check Before After
Template diff against main 0 lines changed 19 insertions, 1 deletion, tick boxes unchanged
Prose sweep on this body not run clean

Closes #2

Automated posting by agentic team with human oversight.

@github-actions github-actions Bot added size: s 11 to 50 lines changed source: contribution A pull request from someone outside the team status: needs triage New: nobody has looked at it yet type: docs Documentation only labels Oct 27, 2026

@ahrazzle ahrazzle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Head checked: bad43e7, base main. One file, .github/pull_request_template.md, 19 insertions, 1 deletion.

The diff adds Root cause, a before and after table under How it was checked, Prior art and claim label, and Disclosure. The tick-box sections are unchanged in the diff.

Checked the bundled test scripts on this head by running them directly. test_templates.py, test_triage.py, test_sync.py, and test_gate.py all passed, with exit 0. The file is markdown only, with no code and no secret-like strings. There were no review threads and no prior reviews.

The body states this closes #2. This review does not merge the pull request.

@orda-aska
orda-aska merged commit 81f83c3 into main Oct 27, 2026
2 checks passed
@orda-aska
orda-aska deleted the template-salvage-from-pr2 branch October 27, 2026 02:00
@github-actions github-actions Bot removed the status: needs triage New: nobody has looked at it yet label Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s 11 to 50 lines changed source: contribution A pull request from someone outside the team type: docs Documentation only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants