Repository navigation
Update Electron, Vite, the React plugin, and Playwright - #89
Merged
Merged
Conversation
Bumps the dependencies group with 6 updates: | Package | From | To | | --- | --- | --- | | [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react) | `6.1.2` | `6.2.1` | | [electron](https://github.com/electron/electron) | `45.2.1` | `45.2.3` | | [jsdom](https://github.com/jsdom/jsdom) | `29.1.1` | `31.0.0` | | [playwright-core](https://github.com/microsoft/playwright) | `1.64.1` | `1.65.0` | | [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `8.3.5` | `8.3.6` | | [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) | `4.1.12` | `5.1.0` | Updates `@vitejs/plugin-react` from 6.1.2 to 6.2.1 - [Release notes](https://github.com/vitejs/vite-plugin-react/releases) - [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-react/commits/[email protected]/packages/plugin-react) Updates `electron` from 45.2.1 to 45.2.3 - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v45.2.1...v45.2.3) Updates `jsdom` from 29.1.1 to 31.0.0 - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v31.0.0) Updates `playwright-core` from 1.64.1 to 1.65.0 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.64.1...v1.65.0) Updates `vite` from 8.3.5 to 8.3.6 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.6/packages/vite) Updates `vitest` from 4.1.12 to 5.1.0 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v5.1.0/packages/vitest) --- updated-dependencies: - dependency-name: "@vitejs/plugin-react" dependency-version: 6.2.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: electron dependency-version: 45.2.3 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: jsdom dependency-version: 31.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: dependencies - dependency-name: playwright-core dependency-version: 1.65.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: vite dependency-version: 8.3.6 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: vitest dependency-version: 5.1.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
Bot
added
dependencies
mberman84
requested changes
Nov 11, 2026
mberman84
left a comment
mberman84
left a comment
Collaborator
There was a problem hiding this comment.
Please split the jsdom and Vitest major upgrades from this dependency update, or update the documented Node support and test its minimum versions in the same PR.
Folio's README and contributor guide say Node 22 or newer. With Node 22.20.0 and npm 10.9.3, npm ci --dry-run --engine-strict --ignore-scripts --offline passes on 264e193. At 29bdd6e the same command fails with EBADENGINE for jsdom 31. Its supported ranges are ^22.22.2 || ^24.15.0 || >=26.0.0. Vitest 5 also drops Node 25. This affects contributor installs with strict engine checks.
The Windows, macOS, and Linux jobs all passed on Node 22.23.4. The Electron, Vite, React plugin, and Playwright updates can go ahead independently with those platform checks.
mberman84
changed the title
mberman84
approved these changes
Nov 14, 2026
mberman84
left a comment
mberman84
left a comment
Collaborator
There was a problem hiding this comment.
The two major test-library upgrades have been split out. I checked the revised lockfile and repeated the previously failing strict install dry-run on Node 22.20.0 with npm 10.9.3. It now passes. Windows, macOS, and Linux CI also passed at bc1f63a. This resolves my earlier change request.
mberman84
deleted the
dependabot/npm_and_yarn/dependencies-84769ca6c2
branch
November 14, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The original dependency group included major test-library upgrades that would change Folio’s documented Node support.
Change
Update Electron from 45.2.1 to 45.2.3, Vite from 8.3.5 to 8.3.6, the React plugin from 6.1.2 to 6.2.1, and Playwright from 1.64.1 to 1.65.0. The jsdom and Vitest upgrades are tracked separately in #94.
Approval and verification
Split at the maintainer’s request. The clean install, unit tests, production build, and full hidden macOS smoke suite passed for these four updates. A strict install dry-run passed with Node 22.20.0 and npm 10.9.3, the combination that failed with jsdom 31. Windows, macOS, and Linux CI passed.
Dependency updates by Dependabot. Split and verified with GPT-6 in Codex.