You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Drag the signature in the placement preview with live feedback #61
In Folio 1.15.1 on macOS, manual signature placement updates only after clicking a position. It is hard to align a signature with a printed line because its position cannot be adjusted by dragging the visible image.
Proposed behavior
Allow dragging the proposed signature in the signing dialog with continuous visual feedback. Preserve the point where it was grabbed, keep it inside the page, and retain keyboard positioning and explicit approval before adding it to the PDF. Moving a suggested placement should switch to manual placement without changing its size.
Scope and related work
#44 already improves signature fields and printed-line detection. This proposal concerns manual positioning in the existing dialog, and should build on or coordinate with that work rather than duplicate its detector. Please confirm the behavior and scope for an upstream contribution.
Use synthetic forms and a synthetic mark for regression coverage and screenshots; no private documents or real signatures are needed.
A focused implementation is available on this branch. The preview follows the pointer while dragging, preserves the initial grab offset and signature size, clamps placement to page boundaries, and restores the previous placement if the gesture is cancelled. Suggested positions can be adjusted directly; keyboard positioning remains available.
The regression fails on the original code and passes with the fix. Tests cover movement before pointer release, no jump at release, page boundaries, keyboard nudging, cancellation, ignoring a different pointer and ignoring right-click. The integrated macOS build passes TypeScript, the production build, and the full off-screen smoke suite. Cross-platform CI has not run because inherited workflows are disabled on the new fork. Synthetic before/after screenshots are available locally; the browser upload was unsuccessful, so no images are attached yet.
Maintainer agreement on this behavior is requested before opening an upstream PR, per CONTRIBUTING.md.
@apexEvan, the manual placement behavior you described is approved. Please open a focused PR from your branch that lets the reader drag the signature preview, keeps keyboard positioning, and waits for confirmation before applying it. #44 covers picking a mark for a detected field or line. Please link the PR here, or confirm you plan to take this step, by November 24 at 5 p.m. Pacific.
Activity
apexEvan commentedon Nov 4, 2026
A focused implementation is available on this branch. The preview follows the pointer while dragging, preserves the initial grab offset and signature size, clamps placement to page boundaries, and restores the previous placement if the gesture is cancelled. Suggested positions can be adjusted directly; keyboard positioning remains available.
The regression fails on the original code and passes with the fix. Tests cover movement before pointer release, no jump at release, page boundaries, keyboard nudging, cancellation, ignoring a different pointer and ignoring right-click. The integrated macOS build passes TypeScript, the production build, and the full off-screen smoke suite. Cross-platform CI has not run because inherited workflows are disabled on the new fork. Synthetic before/after screenshots are available locally; the browser upload was unsuccessful, so no images are attached yet.
Maintainer agreement on this behavior is requested before opening an upstream PR, per CONTRIBUTING.md.
mberman84 commentedon Nov 11, 2026
@apexEvan, the manual placement behavior you described is approved. Please open a focused PR from your branch that lets the reader drag the signature preview, keeps keyboard positioning, and waits for confirmation before applying it. #44 covers picking a mark for a detected field or line. Please link the PR here, or confirm you plan to take this step, by November 24 at 5 p.m. Pacific.