Skip to content

build: upgrade lombok to 1.18.40 with support for Java 25 - #212

Merged
paodb merged 1 commit into
masterfrom
lombok-1.18.40
Jul 27, 2026
Merged

build: upgrade lombok to 1.18.40 with support for Java 25#212
paodb merged 1 commit into
masterfrom
lombok-1.18.40

Conversation

@javier-godoy

@javier-godoy javier-godoy commented Jul 27, 2026

Copy link
Copy Markdown
Member

See https://github.com/FlowingCode/AddonsInternal/issues/202

Summary by CodeRabbit

  • Chores
    • Standardized Lombok version management for more consistent builds.
    • Pinned the Maven compiler plugin version and configured Lombok annotation processing explicitly.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

Lombok build configuration

Layer / File(s) Summary
Centralize Lombok version and annotation processing
pom.xml
Defines Lombok version 1.18.40, reuses it for the dependency, and configures maven-compiler-plugin version 3.13.0 with Lombok annotation processing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: flowingcodeci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: upgrading Lombok to 1.18.40 for Java 25 support.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lombok-1.18.40

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pom.xml`:
- Around line 152-169: Activate the maven-compiler-plugin configuration by
declaring maven-compiler-plugin in the direct build/plugins section so its
annotationProcessorPaths and version are applied; otherwise remove the
pluginManagement entry if annotation processing is intentionally handled
elsewhere.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0811cdb8-afea-4dfd-b014-1e9098fa3f05

📥 Commits

Reviewing files that changed from the base of the PR and between 05fbf88 and 2207cf9.

📒 Files selected for processing (1)
  • pom.xml

Comment thread pom.xml
@javier-godoy
javier-godoy requested a review from paodb July 27, 2026 19:56
@javier-godoy
javier-godoy marked this pull request as ready for review July 27, 2026 19:56
@javier-godoy
javier-godoy requested a review from scardanzan July 27, 2026 19:57
@paodb
paodb merged commit 66fc9e1 into master Jul 27, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from To Do to Pending release in Flowing Code Addons Jul 27, 2026
@paodb
paodb deleted the lombok-1.18.40 branch July 27, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

2 participants