Repository navigation
Create plugin automation types from the automations page - #2871
Open
BelhsanHmida wants to merge 3 commits into
Open
BelhsanHmida wants to merge 3 commits into
BelhsanHmida wants to merge 3 commits into
Conversation
The creation form offered only the built-in types, so plugin types could only be created with the CLI or API. It now lists each installed plugin type under Plugin types, hides the data generator class field for them, and narrows the data source picker to the sources their generator records under. A Copy of a plugin automation now keeps its type and data source too. Signed-off-by: Mohamed Belhsan Hmida <[email protected]>
Documentation build overview
6 files changed ·
|
Signed-off-by: Mohamed Belhsan Hmida <[email protected]>
Signed-off-by: Mohamed Belhsan Hmida <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Plugins can add automation types (#2530), but the New automation form only offered
forecasting,schedulingandreporting, so a plugin automation had to be created with the CLI or the API.This PR lets the form create them. For example, with the EMS plugin installed, New automation → Type → Plugin types →
meent-p1-pulltakes the config (meter-asset,pod-url, …) and parameters as JSON, and Create gives the same automation asflexmeasures add automation --type meent-p1-pull.ingestor, as it doesforecasterfor forecasts andreporterfor reports.start-offset,duration) is only shown for the built-in types: plugin parameters follow the plugin's own schema.No API or plugin changes: the form posts to
POST /api/v3_0/assets/(id)/automations, which already accepts plugin types.How to test
Or by hand: with a plugin that registers an automation type, open an asset's Automations page, choose New automation, pick the type under Plugin types, fill in its config and parameters, and create it. Then choose Copy on it: the form opens with the type and data source filled in.
Further improvements
Related Items
Follow-up to #2530.
closes #2873
Sign-off