feat(auth): surface is_new_user in OAuth login responses#8011
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughOAuth login now tracks whether authentication created a new user. Google and GitHub endpoints return the token key and Estimated code review effort: 2 (Simple) | ~10 minutes Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8011 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 1497 1497
Lines 59287 59295 +8
=======================================
+ Hits 58481 58489 +8
Misses 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)Details
|
Visual Regression19 screenshots compared. See report for details. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Google and GitHub OAuth login responses now include
is_new_user, true when the login created the account. This lets the frontend distinguish OAuth signups from logins, so signup conversion events (see #7979) can also be emitted for OAuth-based signups. No model changes.How did you test this code?
Unit tests: existing OAuth view tests extended to assert
is_new_useristruefor newly created users andfalsefor existing ones.